Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 884063004: Reset manual zoom mode on navigation. (Closed)

Created:
5 years, 10 months ago by wjmaclean
Modified:
5 years, 10 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset manual zoom mode on navigation. When an app/extension places a ZoomController in manual mode, it is reasonable to expect that navigating the main frame should reset that mode, since the app/extension will be reloaded in the process. The root cause of this bug was the sending of a ZoomChangeEvent that contained stale information (the old, manually managed, zoom level), which in turn caused the zoom bubble to be displayed. BUG=450909 Committed: https://crrev.com/96fc2e9e38a10f2bb9f12f26ac6842db71061e09 Cr-Commit-Position: refs/heads/master@{#313576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M chrome/browser/ui/zoom/zoom_controller_browsertest.cc View 2 chunks +34 lines, -19 lines 0 comments Download
M components/ui/zoom/zoom_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
wjmaclean
fsamuel@ - small CL, please take a look?
5 years, 10 months ago (2015-01-28 17:38:18 UTC) #2
Fady Samuel
lgtm
5 years, 10 months ago (2015-01-28 18:37:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884063004/1
5 years, 10 months ago (2015-01-28 19:41:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 20:42:40 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 20:44:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96fc2e9e38a10f2bb9f12f26ac6842db71061e09
Cr-Commit-Position: refs/heads/master@{#313576}

Powered by Google App Engine
This is Rietveld 408576698