Add plumbing for video pixel formats with JPEG color range.

Add plumbing for video pixel formats with JPEG color range.

BUG=310273
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238559

[Sergey Ulanov, 2013-12-02 21:49:08]

https://codereview.chromium.org/88403004/diff/50001/media/base/yuv_convert.h
File media/base/yuv_convert.h (right):

https://codereview.chromium.org/88403004/diff/50001/media/base/yuv_convert.h#...
media/base/yuv_convert.h:32: MPEG,  // [16,235] Y channel, [16,239] U/V
nit: Maybe call it YUV_RANGE_MPEG and YUV_RANGE_JPEG? Also it might be better to
call them YUV_RANGE_RESTRICTED and YUV_RANGE_FULL?

[rileya (GONE FROM CHROMIUM), 2013-12-02 23:10:30]

https://codereview.chromium.org/88403004/diff/50001/media/base/yuv_convert.h
File media/base/yuv_convert.h (right):

https://codereview.chromium.org/88403004/diff/50001/media/base/yuv_convert.h#...
media/base/yuv_convert.h:32: MPEG,  // [16,235] Y channel, [16,239] U/V
On 2013/12/02 21:49:09, Sergey Ulanov wrote:
> nit: Maybe call it YUV_RANGE_MPEG and YUV_RANGE_JPEG? Also it might be better
to
> call them YUV_RANGE_RESTRICTED and YUV_RANGE_FULL?

It's possible that a different range may eventually exist, which would make
RESTRICTED ambiguous, but that's not the case currently and rather unlikely, so
I like RESTRICTED/FULL as more informative names. Done.

[Sergey Ulanov, 2013-12-02 23:12:23]

media - lgtm

[Sergey Ulanov, 2013-12-02 23:12:39]

On 2013/12/02 23:12:23, Sergey Ulanov wrote:
> media - lgtm

sorry, I meant remoting - lgtm

[scherkus (not reviewing), 2013-12-03 00:21:29]

https://codereview.chromium.org/88403004/diff/80014/media/base/yuv_convert.h
File media/base/yuv_convert.h (right):

https://codereview.chromium.org/88403004/diff/80014/media/base/yuv_convert.h#...
media/base/yuv_convert.h:33: YUV_RANGE_FULL,  // "JPEG" Full [0,255] color range
for all channels.
since we don't implement this yet, it'd be preferable to not introduce this enum
+ corresponding changes yet

(if you happen to sideline this work we'll end up checking in an API that isn't
doing anything at the moment)

[rileya (GONE FROM CHROMIUM), 2013-12-03 18:58:54]

https://codereview.chromium.org/88403004/diff/80014/media/base/yuv_convert.h
File media/base/yuv_convert.h (right):

https://codereview.chromium.org/88403004/diff/80014/media/base/yuv_convert.h#...
media/base/yuv_convert.h:33: YUV_RANGE_FULL,  // "JPEG" Full [0,255] color range
for all channels.
On 2013/12/03 00:21:30, scherkus wrote:
> since we don't implement this yet, it'd be preferable to not introduce this
enum
> + corresponding changes yet
> 
> (if you happen to sideline this work we'll end up checking in an API that
isn't
> doing anything at the moment)

Alrighty, removed from this CL.

[scherkus (not reviewing), 2013-12-03 21:28:23]

lgtm

[rileya (GONE FROM CHROMIUM), 2013-12-03 23:29:57]

+danakj for OWNER review: Please have a quick look at the tiny changes to
cc/resources/video_resource_updater.cc

[danakj, 2013-12-03 23:41:29]

ccLGTM

[commit-bot: I haz the power, 2013-12-04 00:14:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rileya@chromium.org/88403004/110001

[commit-bot: I haz the power, 2013-12-04 04:15:16]

Change committed as 238559