Default path renderer batch

Default path renderer batch

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/332c729ceca3db4bde5b6382db5f67ba066ae48a

[joshualitt, 2015-02-17 17:08:19]

joshualitt@google.com changed reviewers:
+ egdaniel@google.com

[joshualitt, 2015-02-17 17:08:27]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-02-17 17:08:27]

ptal

[egdaniel, 2015-02-18 15:16:57]

https://codereview.chromium.org/884013010/diff/100001/src/gpu/GrDefaultPathRe...
File src/gpu/GrDefaultPathRenderer.cpp (right):

https://codereview.chromium.org/884013010/diff/100001/src/gpu/GrDefaultPathRe...
src/gpu/GrDefaultPathRenderer.cpp:462: isIndexed, this->isHairline(),
subpathIdxStart, vertexOffset, &idx);
100 chars

https://codereview.chromium.org/884013010/diff/100001/src/gpu/GrDefaultPathRe...
src/gpu/GrDefaultPathRenderer.cpp:488: // uint16_t currIdx = (uint16_t) (vert -
base);
is the commented line needed for any reason

https://codereview.chromium.org/884013010/diff/100001/src/gpu/GrDefaultPathRe...
src/gpu/GrDefaultPathRenderer.cpp:493: 
was there a reason to remove the asserts in that were in the old version?

[joshualitt, 2015-02-20 14:31:46]

feedback inc

https://codereview.chromium.org/884013010/diff/100001/src/gpu/GrDefaultPathRe...
File src/gpu/GrDefaultPathRenderer.cpp (right):

https://codereview.chromium.org/884013010/diff/100001/src/gpu/GrDefaultPathRe...
src/gpu/GrDefaultPathRenderer.cpp:493: 
On 2015/02/18 15:16:57, egdaniel wrote:
> was there a reason to remove the asserts in that were in the old version?

I put an assert at the end of the whole thing(line 354).  Its probably a bit
more useful to have the assert after every path, so I can move it to the end of
the loop.

[joshualitt, 2015-02-23 14:59:07]

On 2015/02/20 14:31:46, joshualitt wrote:
> feedback inc
> 
>
https://codereview.chromium.org/884013010/diff/100001/src/gpu/GrDefaultPathRe...
> File src/gpu/GrDefaultPathRenderer.cpp (right):
> 
>
https://codereview.chromium.org/884013010/diff/100001/src/gpu/GrDefaultPathRe...
> src/gpu/GrDefaultPathRenderer.cpp:493: 
> On 2015/02/18 15:16:57, egdaniel wrote:
> > was there a reason to remove the asserts in that were in the old version?
> 
> I put an assert at the end of the whole thing(line 354).  Its probably a bit
> more useful to have the assert after every path, so I can move it to the end
of
> the loop.

any other feedback?

[egdaniel, 2015-02-23 15:17:22]

lgtm

[joshualitt, 2015-02-23 15:35:05]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-02-23 15:35:22]

The CQ bit was unchecked by joshualitt@google.com

[joshua.litt, 2015-02-23 16:12:07]

New patchsets have been uploaded after l-g-t-m from egdaniel@google.com

[joshualitt, 2015-02-23 16:26:11]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-02-23 16:26:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/884013010/160001

[commit-bot: I haz the power, 2015-02-23 16:44:35]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/332c729ceca3db4bde5b6382db5f67ba066ae48a

[hiroshige, 2015-02-24 05:26:17]

On 2015/02/23 16:44:35, I haz the power (commit-bot) wrote:
> Committed patchset #9 (id:160001) as
> https://skia.googlesource.com/skia/+/332c729ceca3db4bde5b6382db5f67ba066ae48a

This CL caused WebKit Linux MSAN bot failure (MemorySanitizer:
use-of-uninitialized-value).
https://crbug.com/461187
joshua.litt@, could you take a look?