Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 884003003: Add cache size and number of prefetch tasks limitations to list thumbnail loader. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cache size and number of prefetch tasks limitations to list thumbnail loader. BUG=438050 TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader Committed: https://crrev.com/2cb36e7cdd6d6361318b99335275c80474a86e6b Cr-Commit-Position: refs/heads/master@{#314757}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -31 lines) Patch
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js View 1 13 chunks +31 lines, -23 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js View 4 chunks +62 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-05 03:31:35 UTC) #2
hirono
lgtm! https://codereview.chromium.org/884003003/diff/1/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js File ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js (right): https://codereview.chromium.org/884003003/diff/1/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js#newcode68 ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js:68: * @type {LRUCache<!Object>} Can we type (or add ...
5 years, 10 months ago (2015-02-05 03:51:05 UTC) #3
yawano
Thank you for the review! https://codereview.chromium.org/884003003/diff/1/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js File ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js (right): https://codereview.chromium.org/884003003/diff/1/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js#newcode68 ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js:68: * @type {LRUCache<!Object>} On ...
5 years, 10 months ago (2015-02-05 03:56:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884003003/20001
5 years, 10 months ago (2015-02-05 03:59:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 04:46:44 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 04:47:39 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2cb36e7cdd6d6361318b99335275c80474a86e6b
Cr-Commit-Position: refs/heads/master@{#314757}

Powered by Google App Engine
This is Rietveld 408576698