Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 883993003: Files.app: Add missing externs for FileManagerPrivate APIs. (Closed)

Created:
5 years, 11 months ago by Ben Kwa
Modified:
5 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add missing externs for FileManagerPrivate APIs. searchFilesByHashes computeChecksum BUG=None Committed: https://crrev.com/1064215ca1a3d218ec711eef1dae415e4650933e Cr-Commit-Position: refs/heads/master@{#313455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/closure_compiler/externs/file_manager_private.js View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Kwa
5 years, 11 months ago (2015-01-28 03:52:31 UTC) #2
fukino
lgtm.
5 years, 11 months ago (2015-01-28 04:10:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883993003/1
5 years, 11 months ago (2015-01-28 06:12:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-28 06:45:36 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 06:46:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1064215ca1a3d218ec711eef1dae415e4650933e
Cr-Commit-Position: refs/heads/master@{#313455}

Powered by Google App Engine
This is Rietveld 408576698