Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 883983004: Rename SkyDebugger to KioskWM and move to /services (Closed)

Created:
5 years, 10 months ago by eseidel
Modified:
5 years, 10 months ago
Reviewers:
jamesr, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename SkyDebugger to KioskWM and move to /services Already other applications use sky's simple window manager (mojo:sky_debugger) as a full-screen window manager. This moves this to /services and removes all sky references from it. As a part of this I've removed inspector support from skydb. It was already broken and will need to be re-thought to not involve calls into this new window manager. I'm also flipping the relationship between prompt.cc and debugger.cc for skydb. Skydb will tell mojo_shell to start sky_debugger_prompt instead of sky_debugger. I'm also renaming sky_debugger_prompt to be sky_debugger. R=abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/dadb7ec072038faa89793f6c4b5805d6714390f6

Patch Set 1 #

Patch Set 2 : Move to /services instead of /mojo/services #

Patch Set 3 : Ready for review #

Patch Set 4 : Rename to KioskWM per discussion with jamesr #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -700 lines) Patch
M services/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + services/kiosk_wm/BUILD.gn View 1 2 3 2 chunks +3 lines, -20 lines 0 comments Download
A + services/kiosk_wm/main.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
A + services/kiosk_wm/navigator_host_impl.h View 1 2 3 1 chunk +15 lines, -13 lines 1 comment Download
A + services/kiosk_wm/navigator_host_impl.cc View 1 2 3 2 chunks +12 lines, -10 lines 0 comments Download
M sky/tools/debugger/BUILD.gn View 1 1 chunk +11 lines, -19 lines 0 comments Download
M sky/tools/debugger/debugger.h View 1 1 chunk +0 lines, -90 lines 0 comments Download
M sky/tools/debugger/debugger.cc View 1 1 chunk +186 lines, -101 lines 0 comments Download
M sky/tools/debugger/debugger.mojom View 1 1 chunk +0 lines, -11 lines 0 comments Download
M sky/tools/debugger/main.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download
M sky/tools/debugger/navigator_host_impl.h View 1 1 chunk +0 lines, -37 lines 0 comments Download
M sky/tools/debugger/navigator_host_impl.cc View 1 1 chunk +0 lines, -31 lines 0 comments Download
D sky/tools/debugger/prompt/BUILD.gn View 1 1 chunk +0 lines, -30 lines 0 comments Download
M sky/tools/debugger/prompt/prompt.cc View 1 1 chunk +0 lines, -230 lines 0 comments Download
M sky/tools/debugger/prompt/trace_collector.h View 1 1 chunk +0 lines, -40 lines 0 comments Download
M sky/tools/debugger/prompt/trace_collector.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
A + sky/tools/debugger/trace_collector.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/tools/debugger/trace_collector.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/skydb View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
eseidel
5 years, 10 months ago (2015-01-29 19:04:18 UTC) #1
eseidel
Ready for review.
5 years, 10 months ago (2015-01-29 19:14:50 UTC) #3
abarth-chromium
lgtm
5 years, 10 months ago (2015-01-29 19:24:01 UTC) #4
eseidel
Committed patchset #4 (id:60001) manually as dadb7ec072038faa89793f6c4b5805d6714390f6 (presubmit successful).
5 years, 10 months ago (2015-01-29 19:26:04 UTC) #5
jamesr
https://codereview.chromium.org/883983004/diff/60001/services/kiosk_wm/navigator_host_impl.h File services/kiosk_wm/navigator_host_impl.h (right): https://codereview.chromium.org/883983004/diff/60001/services/kiosk_wm/navigator_host_impl.h#newcode11 services/kiosk_wm/navigator_host_impl.h:11: #include "sky/tools/debugger/debugger.mojom.h" this introduced the following interesting build flake: ...
5 years, 10 months ago (2015-01-29 20:35:37 UTC) #6
jamesr
Actually *nothing* produces that header, anywhere
5 years, 10 months ago (2015-01-29 20:36:27 UTC) #7
eseidel
5 years, 10 months ago (2015-01-29 20:51:38 UTC) #8
Message was sent while issue was closed.
You just have to BELIEVE in the header.

Have FAITH.

Or I could just remove it for you:
6d1dae08560e11b4da25f0f18acbb79032f36970

Powered by Google App Engine
This is Rietveld 408576698