Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 883983003: Replace the term "main-frame" in content_settings.json. (Closed)

Created:
5 years, 10 months ago by msramek
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace the term "main-frame" in content_settings.json. Following the discussion about the term "main-frame" in https://codereview.chromium.org/843413003/, I experimented with a testing webpage that embedded <iframe>s which triggered different content setting requests. Apparently, in the descriptions in content_settings.json, we used the term "main-frame" in two different contexts. This CL get rids of the term completely in favor of "top-level frame" and "document which requests X". BUG=447978 Committed: https://crrev.com/6c9e3b3dd185d169364657a36a176b273b38e9e5 Cr-Commit-Position: refs/heads/master@{#313889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/common/extensions/api/content_settings.json View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
msramek
Hi Mike and Bernhard, Confused by your recent discussion on "main-frame", I tested all the ...
5 years, 10 months ago (2015-01-28 14:37:42 UTC) #4
Mike West
LGTM, as I assume you did the research correctly. :) Bernhard might have comments, however. ...
5 years, 10 months ago (2015-01-28 20:36:58 UTC) #5
Bernhard Bauer
lgtm
5 years, 10 months ago (2015-01-29 17:31:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883983003/40001
5 years, 10 months ago (2015-01-30 09:27:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 10 months ago (2015-01-30 09:31:04 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 09:31:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c9e3b3dd185d169364657a36a176b273b38e9e5
Cr-Commit-Position: refs/heads/master@{#313889}

Powered by Google App Engine
This is Rietveld 408576698