Add -pedantic to Makefile.standalone to match production.

src/IceDefs.h

 //===- subzero/src/IceDefs.h - Common Subzero declaraions -------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares various useful types and classes that have
@@ skipping 111 matching lines @@
 
 typedef uint32_t TimerStackIdT;
 typedef uint32_t TimerIdT;
 
 // Use alignas(MaxCacheLineSize) to isolate variables/fields that
 // might be contended while multithreading.  Assumes the maximum cache
 // line size is 64.
 enum { MaxCacheLineSize = 64 };
 // Use ICE_CACHELINE_BOUNDARY to force the next field in a declaration
 // list to be aligned to the next cache line.
+#define TOKENPASTE(x, y) x##y
+#define TOKENPASTE2(x, y) TOKENPASTE(x, y)
 #define ICE_CACHELINE_BOUNDARY                                                 \
-  alignas(MaxCacheLineSize) struct {}
+  void TOKENPASTE2(FakeUsage, __LINE__)() {                                    \
+    (void) TOKENPASTE2(Boundary, __LINE__);                                    \
+  }                                                                            \
+  alignas(MaxCacheLineSize) struct TOKENPASTE2(FakeType, __LINE__) {           \
+  } TOKENPASTE2(Boundary, __LINE__)

[JF, 2015/01/28 01:28:45]

You don't need the fake usage as long as you instantiate the struct.

But all of this is in vain because the struct must occupy some storage, it isn't
zero-sized... So we're back to:

  __attribute__((aligned(Align))) int : 0;

[Jim Stichnoth, 2015/01/28 03:26:37]

Done.

[JF, 2015/01/28 07:14:45]

Richard makes a good point that you can wrap each field you want to be together
in an anonymous struct, and make that struct alignas.

That would be standard-friendly and more readable.

[Jim Stichnoth, 2015/01/28 15:39:18]

Yeah, that is pretty nice and clear.  Except is there a good way to initialize
the fields that are now wrapped inside an anonymous struct?  E.g. this
conversion from MyClass1 to MyClass2:

class MyClass1 {
  std::mutex MyFieldLock;
  MyType MyField;
public:
  MyClass1(ArgType Arg) : MyField(Arg) {}
};

class MyClass2 {
  alignas(64) struct {
    std::mutex MyFieldLock;
    MyType MyField;
  } F;
public:
  // This doesn't work:
  // MyClass2(ArgType Arg) : F.MyField(Arg) {}
  // This may work, depending on MyType and ArgType:
  MyClass2(ArgType Arg) { F.MyField = Arg; }
};

The other issue is that if you have N fields needing cache alignment, you
generally want N+1 instances of alignas(), so that fields after the explicitly
aligned ones start on a new cache line.  So even with the aligned (anonymous)
struct solution, you still need one more boundary marker.

 
 // PNaCl is ILP32, so theoretically we should only need 32-bit offsets.
 typedef int32_t RelocOffsetT;
 enum { RelocAddrSize = 4 };
 
 enum LivenessMode {
   // Basic version of live-range-end calculation.  Marks the last uses
   // of variables based on dataflow analysis.  Records the set of
   // live-in and live-out variables for each block.  Identifies and
   // deletes dead instructions (primarily stores).
@@ skipping 64 matching lines @@
   return llvm::make_range(Container.rbegin(), Container.rend());
 }
 template <typename T>
 llvm::iterator_range<typename T::reverse_iterator> reverse_range(T &Container) {
   return llvm::make_range(Container.rbegin(), Container.rend());
 }
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEDEFS_H