Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 883973002: Move cloud import button to toolbar, make material designey. (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org, mtomasz, Ben Kwa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move cloud import button to toolbar, make material designey. This is the first of several steps in bringing a material design friendly cloud import feature. BUG=420680 TEST=browser_test: FileManagerJsTest.* Committed: https://crrev.com/440dad13b373bb055df0273e99f865a84912e77b Cr-Commit-Position: refs/heads/master@{#313426}

Patch Set 1 #

Patch Set 2 : Add test coverage for new command update logic. Fix a type, and undo some early debug code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -59 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 3 chunks +4 lines, -16 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 chunk +0 lines, -30 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 7 chunks +88 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller_unittest.js View 1 3 chunks +28 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
fukino
lgtm.
5 years, 10 months ago (2015-01-28 01:07:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883973002/1
5 years, 10 months ago (2015-01-28 01:09:11 UTC) #4
Steve McKay
Add test coverage for new command update logic.
5 years, 10 months ago (2015-01-28 01:20:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883973002/20001
5 years, 10 months ago (2015-01-28 01:22:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883973002/60001
5 years, 10 months ago (2015-01-28 01:26:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 10 months ago (2015-01-28 04:08:20 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 04:09:44 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/440dad13b373bb055df0273e99f865a84912e77b
Cr-Commit-Position: refs/heads/master@{#313426}

Powered by Google App Engine
This is Rietveld 408576698