Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1988)

Issue 883963002: Fix left-side navigation for top-level pages (Closed)

Created:
5 years, 11 months ago by mkearney1
Modified:
5 years, 10 months ago
CC:
chromium-reviews, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, Sam Clegg, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix left-side navigation for top-level pages And don't break presubmit! Basically, the change I put in previously that kind of fixed extensions redirects actually meant presubmit would fail. So I've gone and put in a real fix. I also updated the redirects.json files in these GitHub repos for this to work: devtools, multi-device, and store. Thanks, Ben, for your help. Committed: https://crrev.com/5b6eddeb5ee523ab4299ab8e83f6d42c19ad4b2f Cr-Commit-Position: refs/heads/master@{#313575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/extensions/redirects.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/redirects.json View 1 chunk +1 line, -6 lines 0 comments Download
A native_client_sdk/doc_generated/redirects.json View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-01-28 18:54:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883963002/1
5 years, 10 months ago (2015-01-28 19:53:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38975)
5 years, 10 months ago (2015-01-28 19:59:23 UTC) #6
mkearney1
Ben, I need an lgtm from a native-client owner. Thanks, Meggin
5 years, 10 months ago (2015-01-28 20:04:28 UTC) #7
Ken Rockot(use gerrit already)
Brad could you please take a look for the NaCl doc change? I think it's ...
5 years, 10 months ago (2015-01-28 20:05:51 UTC) #9
bradn
lgtm
5 years, 10 months ago (2015-01-28 20:15:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883963002/1
5 years, 10 months ago (2015-01-28 20:18:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38988)
5 years, 10 months ago (2015-01-28 20:23:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883963002/1
5 years, 10 months ago (2015-01-28 20:26:37 UTC) #18
mkearney1
On 2015/01/28 20:23:59, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-01-28 20:26:51 UTC) #19
binji
native_client_sdk lgtm
5 years, 10 months ago (2015-01-28 20:28:43 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883963002/1
5 years, 10 months ago (2015-01-28 20:30:36 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 20:41:13 UTC) #25
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 20:42:07 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b6eddeb5ee523ab4299ab8e83f6d42c19ad4b2f
Cr-Commit-Position: refs/heads/master@{#313575}

Powered by Google App Engine
This is Rietveld 408576698