Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 883953002: Add content public APIs for Presentation API. (Closed)

Created:
5 years, 11 months ago by imcheng (use chromium acct)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, whywhat, mark a. foltz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add content public APIs for Presentation API. The pieces added are as follows: 1. PresentationServiceDelegate: An interface to be implemented by an embedder to handle Presentation API requests. Includes an Observer interface to observe the lifetime of the delegate object. 2. PresentationScreenAvailabilityListener: An interface to be implemented by content/ code to receive screen availability results from the embedder. 3. Added method to ContentBrowserClient: GetPresentationServiceDelegate. Returns nullptr by default. Embedder may override it with an implementation that can handle Presentation API requests. Added to allow content/ code to obtain a reference to a PresentationServiceDelegate to forward presentation API requests to. Presentation Mojo service patch: crrev.com/839773002/ Blink plumbing: crrev.com/832263007 The Chrome implementation of PresentationServiceDelegate is currently in a private repo. BUG=412331 Committed: https://crrev.com/11c9dde535c6b288d6a65f2ee5dfc0efd6a970d4 Cr-Commit-Position: refs/heads/master@{#313563}

Patch Set 1 : Initial patch #

Total comments: 4

Patch Set 2 : Addressed Avi's comments #

Total comments: 4

Patch Set 3 : Removed presentation_url #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -0 lines) Patch
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A content/public/browser/presentation_screen_availability_listener.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A content/public/browser/presentation_service_delegate.h View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
imcheng
Hi Avi, Please review everything in this patch. It contains purely content/public/browser changes. Anton and ...
5 years, 11 months ago (2015-01-28 00:35:10 UTC) #3
Avi (use Gerrit)
Minor nits to the design, but nothing huge. https://codereview.chromium.org/883953002/diff/20001/content/public/browser/presentation_screen_availability_listener.h File content/public/browser/presentation_screen_availability_listener.h (right): https://codereview.chromium.org/883953002/diff/20001/content/public/browser/presentation_screen_availability_listener.h#newcode13 content/public/browser/presentation_screen_availability_listener.h:13: // ...
5 years, 11 months ago (2015-01-28 01:02:49 UTC) #5
imcheng
https://codereview.chromium.org/883953002/diff/20001/content/public/browser/presentation_screen_availability_listener.h File content/public/browser/presentation_screen_availability_listener.h (right): https://codereview.chromium.org/883953002/diff/20001/content/public/browser/presentation_screen_availability_listener.h#newcode13 content/public/browser/presentation_screen_availability_listener.h:13: // asscociated with a presentation URL from an embedder. ...
5 years, 11 months ago (2015-01-28 01:37:24 UTC) #7
Avi (use Gerrit)
Almost there. I want to keep the API layer as clean as possible. https://codereview.chromium.org/883953002/diff/40001/content/public/browser/presentation_screen_availability_listener.h File ...
5 years, 11 months ago (2015-01-28 02:32:49 UTC) #8
Avi (use Gerrit)
Also, where are your tryjobs?
5 years, 11 months ago (2015-01-28 02:33:04 UTC) #9
imcheng
Thanks. Launched try jobs just now. https://codereview.chromium.org/883953002/diff/40001/content/public/browser/presentation_screen_availability_listener.h File content/public/browser/presentation_screen_availability_listener.h (right): https://codereview.chromium.org/883953002/diff/40001/content/public/browser/presentation_screen_availability_listener.h#newcode18 content/public/browser/presentation_screen_availability_listener.h:18: : presentation_url_(presentation_url) {} ...
5 years, 10 months ago (2015-01-28 18:00:39 UTC) #10
Avi (use Gerrit)
lgtm Looks good.
5 years, 10 months ago (2015-01-28 18:05:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883953002/60001
5 years, 10 months ago (2015-01-28 18:47:08 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-01-28 19:43:59 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 19:45:50 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/11c9dde535c6b288d6a65f2ee5dfc0efd6a970d4
Cr-Commit-Position: refs/heads/master@{#313563}

Powered by Google App Engine
This is Rietveld 408576698