Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 883913003: Roll PDFium. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium. This brings in: b3a788e Fix GN PDFium build when building all. f8af677 Always use the FreeType headers included in PDFium. 7dc63e6 Fix heap buffer overflow in CPDF_SampledFunc::v_Call dc8c950 Don't export any OpenJPEG methods from PDFium. 71c24b8 Use system FreeType on Linux. b38a900 Track formhandles in EmbedderTest class itself 14b2bb0 Fix infinite recursion in CPDF_RenderStatus::RenderSingleObject(). 1d43e82 Add minimized test cases for stack exhaustion crash to repository. cedc562 Merge to Master: Add output scale factor command line parameter to pdfium_test. 90f9e61 Merge to Master: Cover fpdftext.h API with embeddertests. 506e6dc Add embedder test for stream length beyond end of file. TBR=tsepez Committed: https://crrev.com/dca0c18ebf3150f46c3e3d9be73a387d0f34ccc7 Cr-Commit-Position: refs/heads/master@{#314099}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
jam
5 years, 10 months ago (2015-01-31 01:19:29 UTC) #2
jam
hmm there are some issues on trybots, I'll fix that and let you know.
5 years, 10 months ago (2015-01-31 01:29:39 UTC) #3
jam
hmm this is failing compile on bots but passing locally. the reason is that locally ...
5 years, 10 months ago (2015-01-31 02:47:32 UTC) #4
brettw
If you have the headers, I don't see anything wrong with just using them. You ...
5 years, 10 months ago (2015-01-31 03:36:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883913003/20001
5 years, 10 months ago (2015-02-01 19:26:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/55023)
5 years, 10 months ago (2015-02-01 19:31:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883913003/40001
5 years, 10 months ago (2015-02-02 00:21:32 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-02 01:42:57 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/dca0c18ebf3150f46c3e3d9be73a387d0f34ccc7 Cr-Commit-Position: refs/heads/master@{#314099}
5 years, 10 months ago (2015-02-02 01:43:45 UTC) #14
Tom Sepez
5 years, 4 months ago (2015-08-14 22:32:34 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698