Fix truncation warning in PEImage on VS2015

base/win/pe_image.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file was adapted from GreenBorder's Code.
 // To understand what this class is about (for other than well known functions
 // as GetProcAddress), a good starting point is "An In-Depth Look into the
 // Win32 Portable Executable File Format" by Matt Pietrek:
 // http://msdn.microsoft.com/msdnmag/issues/02/02/PE/default.aspx
 
@@ skipping 224 matching lines @@
  public:
   explicit PEImageAsData(HMODULE hModule) : PEImage(hModule) {}
 
   virtual PVOID RVAToAddr(DWORD rva) const;
 };
 
 inline bool PEImage::IsOrdinal(LPCSTR name) {
 #pragma warning(push)
 #pragma warning(disable: 4311)
   // This cast generates a warning because it is 32 bit specific.
   return reinterpret_cast<DWORD>(name) <= 0xFFFF;

[grt (UTC plus 2), 2015/01/27 20:55:56]

should this be
   return reinterpret_cast<uintptr_t>(name) <= 0xFFFF;
? note the 'u' so 0x80000123 isn't considered an ordinal.

[Will Harris, 2015/01/27 21:36:04]

my understanding was that 0x80000001 was an ordinal, but the ordinal was 1.

so a check for IsOrdinal should be something like checking the high bit e.g. &
0x80000000 on 32-bit and 0x8000000000000000 on 64-bit.

see http://www.openwatcom.org/ftp/devel/docs/pecoff.pdf section 6.4.2

[scottmg, 2015/01/27 21:42:04]

Done.

 #pragma warning(pop)
 }
 
 inline WORD PEImage::ToOrdinal(LPCSTR name) {
-  return reinterpret_cast<WORD>(name);
+  return static_cast<WORD>(reinterpret_cast<intptr_t>(name));
 }
 
 inline HMODULE PEImage::module() const {
   return module_;
 }
 
 inline PIMAGE_IMPORT_DESCRIPTOR PEImage::GetFirstImportChunk() const {
   return reinterpret_cast<PIMAGE_IMPORT_DESCRIPTOR>(
              GetImageDirectoryEntryAddr(IMAGE_DIRECTORY_ENTRY_IMPORT));
 }
 
 inline PIMAGE_EXPORT_DIRECTORY PEImage::GetExportDirectory() const {
   return reinterpret_cast<PIMAGE_EXPORT_DIRECTORY>(
              GetImageDirectoryEntryAddr(IMAGE_DIRECTORY_ENTRY_EXPORT));
 }
 
 }  // namespace win
 }  // namespace base
 
 #endif  // BASE_WIN_PE_IMAGE_H_