Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 883853003: Fix variable shadowing warning in logging on VS2015 (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-registry
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix variable shadowing warning in logging on VS2015 d:\src\cr3\src\base\logging.cc(167): error C2220: warning treated as error - no 'object' file generated d:\src\cr3\src\base\logging.cc(167): warning C4459: declaration of 'log_file' hides global declaration d:\src\cr3\src\base\logging.cc(103): note: see declaration of 'logging::`anonymous-namespace'::log_file' There was 3 different things called log_file in this file: a global FileHandle, a local PathString, and a PathChar* member variable in LoggingSettings. :/ (Should probably rename all the globals to g_ prefixed in a followup.) R=thakis@chromium.org BUG=440500 Committed: https://crrev.com/fc5b7077362f170c9205dc976dbd144c6f6bd017 Cr-Commit-Position: refs/heads/master@{#313364}

Patch Set 1 #

Patch Set 2 : dewrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M base/logging.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
5 years, 11 months ago (2015-01-27 20:28:00 UTC) #2
Nico
LoG_naMe … aww, no T :-/ lgtm
5 years, 11 months ago (2015-01-27 20:30:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883853003/40001
5 years, 11 months ago (2015-01-27 20:30:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 11 months ago (2015-01-27 21:46:55 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 21:47:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc5b7077362f170c9205dc976dbd144c6f6bd017
Cr-Commit-Position: refs/heads/master@{#313364}

Powered by Google App Engine
This is Rietveld 408576698