Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 883833002: Remove unused methods from SkScalerContext. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unused methods from SkScalerContext. The methods getLocalMatrixWithoutTextSize and getSingleMatrixWithoutTextSize on SkScalerContext were added as a temporary measure for CoreText issues. Now that the CoreText SkScalerContext is using other means to fix these issues more completely, remove these now unused methods. Committed: https://skia.googlesource.com/skia/+/8ece6eb37b4f3c98587efa071ce565d26b156e9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M src/core/SkScalerContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkScalerContext.cpp View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-skia
5 years, 10 months ago (2015-01-27 18:54:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883833002/1
5 years, 10 months ago (2015-01-27 18:54:59 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-27 18:55:00 UTC) #5
mtklein
lgtm
5 years, 10 months ago (2015-01-27 18:59:31 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 19:01:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8ece6eb37b4f3c98587efa071ce565d26b156e9a

Powered by Google App Engine
This is Rietveld 408576698