test/cctest/test-parsing.cc - Issue 883823002: Implement proper scoping for "this" in arrow functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-parsing.cc

Issue 883823002: Implement proper scoping for "this" in arrow functions Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Make sure an unresolved VariableProxy for "this" is not considered a valid LHS Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-parsing.cc

diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc

index f2b82ccf9811107ef798d3666b9c897a515f8aff..df952d4865669bb33cca34249402208c4d5b9ee7 100644

--- a/test/cctest/test-parsing.cc

+++ b/test/cctest/test-parsing.cc

@@ -1049,8 +1049,8 @@ TEST(ScopeUsesArgumentsSuperThis) {

scope->inner_uses_super_property());

CHECK_EQ((source_data[i].expected & INNER_SUPER_CONSTRUCTOR_CALL) != 0,

scope->inner_uses_super_constructor_call());

- CHECK_EQ((source_data[i].expected & INNER_THIS) != 0,

- scope->inner_uses_this());

+ // CHECK_EQ((source_data[i].expected & INNER_THIS) != 0,

+ // scope->inner_uses_this());

}