Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2622)

Unified Diff: src/preparser.h

Issue 883823002: Implement proper scoping for "this" in arrow functions Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Make sure an unresolved VariableProxy for "this" is not considered a valid LHS Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/preparser.h
diff --git a/src/preparser.h b/src/preparser.h
index e2929b827d238d120528f2393a0160b1b3c4aaa0..fabb5074772aeee7b10f7f3b43a222666340603a 100644
--- a/src/preparser.h
+++ b/src/preparser.h
@@ -1019,7 +1019,6 @@ class PreParserScope {
void RecordArgumentsUsage() {}
void RecordSuperPropertyUsage() {}
void RecordSuperConstructorCallUsage() {}
- void RecordThisUsage() {}
// Allow scope->Foo() to work.
PreParserScope* operator->() { return this; }
@@ -1855,7 +1854,6 @@ ParserBase<Traits>::ParsePrimaryExpression(bool* ok) {
switch (token) {
case Token::THIS: {
Consume(Token::THIS);
- scope_->RecordThisUsage();
result = this->ThisExpression(scope_, factory());
break;
}

Powered by Google App Engine
This is Rietveld 408576698