src/parser.cc - Issue 883823002: Implement proper scoping for "this" in arrow functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 883823002: Implement proper scoping for "this" in arrow functions Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Make sure an unresolved VariableProxy for "this" is not considered a valid LHS Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 51e79bb14cf1c6519de925d6bb1434e06ccc225f..73afb0b541efd6fc7f672af4b9c46d4c529276fd 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -674,7 +674,11 @@ const AstRawString* ParserTraits::GetNextSymbol(Scanner* scanner) {

Expression* ParserTraits::ThisExpression(Scope* scope, AstNodeFactory* factory,

int pos) {

- return factory->NewVariableProxy(scope->receiver(), pos);

+ return scope->NewUnresolved(factory,

+ ast_value_factory()->this_string(),

+ Interface::NewValue(),

+ RelocInfo::kNoPosition,

+ true);

}

Expression* ParserTraits::SuperReference(Scope* scope, AstNodeFactory* factory,