src/variables.cc - Issue 883823002: Implement proper scoping for "this" in arrow functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/variables.cc

Issue 883823002: Implement proper scoping for "this" in arrow functions Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: mjsunit/debug-scopes: Skip "this" the same as "arguments" Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/variables.cc

diff --git a/src/variables.cc b/src/variables.cc

index 3b1559d8645301d8f3e152bb69433a1baede518f..e64042679199b0506e1d600a4f993c515ac7c6b8 100644

--- a/src/variables.cc

+++ b/src/variables.cc

@@ -33,8 +33,7 @@ const char* Variable::Mode2String(VariableMode mode) {

Variable::Variable(Scope* scope, const AstRawString* name, VariableMode mode,

- bool is_valid_ref, Kind kind,

- InitializationFlag initialization_flag,

+ Kind kind, InitializationFlag initialization_flag,

MaybeAssignedFlag maybe_assigned_flag, Interface* interface)

: scope_(scope),

name_(name),

@@ -44,7 +43,6 @@ Variable::Variable(Scope* scope, const AstRawString* name, VariableMode mode,

index_(-1),

initializer_position_(RelocInfo::kNoPosition),

local_if_not_shadowed_(NULL),

- is_valid_ref_(is_valid_ref),

force_context_allocation_(false),

is_used_(false),

initialization_flag_(initialization_flag),