Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Side by Side Diff: src/mips64/full-codegen-mips64.cc

Issue 883823002: Implement proper scoping for "this" in arrow functions Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Make sure an unresolved VariableProxy for "this" is not considered a valid LHS Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 #ifdef DEBUG 127 #ifdef DEBUG
128 if (strlen(FLAG_stop_at) > 0 && 128 if (strlen(FLAG_stop_at) > 0 &&
129 info->function()->name()->IsUtf8EqualTo(CStrVector(FLAG_stop_at))) { 129 info->function()->name()->IsUtf8EqualTo(CStrVector(FLAG_stop_at))) {
130 __ stop("stop-at"); 130 __ stop("stop-at");
131 } 131 }
132 #endif 132 #endif
133 133
134 // Sloppy mode functions and builtins need to replace the receiver with the 134 // Sloppy mode functions and builtins need to replace the receiver with the
135 // global proxy when called as functions (without an explicit receiver 135 // global proxy when called as functions (without an explicit receiver
136 // object). 136 // object).
137 if (info->strict_mode() == SLOPPY && !info->is_native()) { 137 if (info->strict_mode() == SLOPPY && !info->is_native() &&
138 info->scope()->has_this_declaration()) {
138 Label ok; 139 Label ok;
139 int receiver_offset = info->scope()->num_parameters() * kPointerSize; 140 int receiver_offset = info->scope()->num_parameters() * kPointerSize;
140 __ ld(at, MemOperand(sp, receiver_offset)); 141 __ ld(at, MemOperand(sp, receiver_offset));
141 __ LoadRoot(a2, Heap::kUndefinedValueRootIndex); 142 __ LoadRoot(a2, Heap::kUndefinedValueRootIndex);
142 __ Branch(&ok, ne, a2, Operand(at)); 143 __ Branch(&ok, ne, a2, Operand(at));
143 144
144 __ ld(a2, GlobalObjectOperand()); 145 __ ld(a2, GlobalObjectOperand());
145 __ ld(a2, FieldMemOperand(a2, GlobalObject::kGlobalProxyOffset)); 146 __ ld(a2, FieldMemOperand(a2, GlobalObject::kGlobalProxyOffset));
146 147
147 __ sd(a2, MemOperand(sp, receiver_offset)); 148 __ sd(a2, MemOperand(sp, receiver_offset));
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 __ push(a1); 215 __ push(a1);
215 __ CallRuntime(Runtime::kNewFunctionContext, 1); 216 __ CallRuntime(Runtime::kNewFunctionContext, 1);
216 } 217 }
217 function_in_register = false; 218 function_in_register = false;
218 // Context is returned in v0. It replaces the context passed to us. 219 // Context is returned in v0. It replaces the context passed to us.
219 // It's saved in the stack and kept live in cp. 220 // It's saved in the stack and kept live in cp.
220 __ mov(cp, v0); 221 __ mov(cp, v0);
221 __ sd(v0, MemOperand(fp, StandardFrameConstants::kContextOffset)); 222 __ sd(v0, MemOperand(fp, StandardFrameConstants::kContextOffset));
222 // Copy any necessary parameters into the context. 223 // Copy any necessary parameters into the context.
223 int num_parameters = info->scope()->num_parameters(); 224 int num_parameters = info->scope()->num_parameters();
224 for (int i = 0; i < num_parameters; i++) { 225 int first_parameter = info->scope()->has_this_declaration() ? -1 : 0;
225 Variable* var = scope()->parameter(i); 226 for (int i = first_parameter; i < num_parameters; i++) {
227 Variable* var = (i == -1) ? scope()->receiver() : scope()->parameter(i);
226 if (var->IsContextSlot()) { 228 if (var->IsContextSlot()) {
227 int parameter_offset = StandardFrameConstants::kCallerSPOffset + 229 int parameter_offset = StandardFrameConstants::kCallerSPOffset +
228 (num_parameters - 1 - i) * kPointerSize; 230 (num_parameters - 1 - i) * kPointerSize;
229 // Load parameter from stack. 231 // Load parameter from stack.
230 __ ld(a0, MemOperand(fp, parameter_offset)); 232 __ ld(a0, MemOperand(fp, parameter_offset));
231 // Store it in the context. 233 // Store it in the context.
232 MemOperand target = ContextOperand(cp, var->index()); 234 MemOperand target = ContextOperand(cp, var->index());
233 __ sd(a0, target); 235 __ sd(a0, target);
234 236
235 // Update the write barrier. 237 // Update the write barrier.
(...skipping 5116 matching lines...) Expand 10 before | Expand all | Expand 10 after
5352 Assembler::target_address_at(pc_immediate_load_address)) == 5354 Assembler::target_address_at(pc_immediate_load_address)) ==
5353 reinterpret_cast<uint64_t>( 5355 reinterpret_cast<uint64_t>(
5354 isolate->builtins()->OsrAfterStackCheck()->entry())); 5356 isolate->builtins()->OsrAfterStackCheck()->entry()));
5355 return OSR_AFTER_STACK_CHECK; 5357 return OSR_AFTER_STACK_CHECK;
5356 } 5358 }
5357 5359
5358 5360
5359 } } // namespace v8::internal 5361 } } // namespace v8::internal
5360 5362
5361 #endif // V8_TARGET_ARCH_MIPS64 5363 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698