Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 883823002: Implement proper scoping for "this" in arrow functions Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Make sure an unresolved VariableProxy for "this" is not considered a valid LHS Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 #ifdef DEBUG 127 #ifdef DEBUG
128 if (strlen(FLAG_stop_at) > 0 && 128 if (strlen(FLAG_stop_at) > 0 &&
129 info->function()->name()->IsUtf8EqualTo(CStrVector(FLAG_stop_at))) { 129 info->function()->name()->IsUtf8EqualTo(CStrVector(FLAG_stop_at))) {
130 __ stop("stop-at"); 130 __ stop("stop-at");
131 } 131 }
132 #endif 132 #endif
133 133
134 // Sloppy mode functions and builtins need to replace the receiver with the 134 // Sloppy mode functions and builtins need to replace the receiver with the
135 // global proxy when called as functions (without an explicit receiver 135 // global proxy when called as functions (without an explicit receiver
136 // object). 136 // object).
137 if (info->strict_mode() == SLOPPY && !info->is_native()) { 137 if (info->strict_mode() == SLOPPY && !info->is_native() &&
138 info->scope()->has_this_declaration()) {
138 Label ok; 139 Label ok;
139 int receiver_offset = info->scope()->num_parameters() * kPointerSize; 140 int receiver_offset = info->scope()->num_parameters() * kPointerSize;
140 __ lw(at, MemOperand(sp, receiver_offset)); 141 __ lw(at, MemOperand(sp, receiver_offset));
141 __ LoadRoot(a2, Heap::kUndefinedValueRootIndex); 142 __ LoadRoot(a2, Heap::kUndefinedValueRootIndex);
142 __ Branch(&ok, ne, a2, Operand(at)); 143 __ Branch(&ok, ne, a2, Operand(at));
143 144
144 __ lw(a2, GlobalObjectOperand()); 145 __ lw(a2, GlobalObjectOperand());
145 __ lw(a2, FieldMemOperand(a2, GlobalObject::kGlobalProxyOffset)); 146 __ lw(a2, FieldMemOperand(a2, GlobalObject::kGlobalProxyOffset));
146 147
147 __ sw(a2, MemOperand(sp, receiver_offset)); 148 __ sw(a2, MemOperand(sp, receiver_offset));
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 __ push(a1); 218 __ push(a1);
218 __ CallRuntime(Runtime::kNewFunctionContext, 1); 219 __ CallRuntime(Runtime::kNewFunctionContext, 1);
219 } 220 }
220 function_in_register = false; 221 function_in_register = false;
221 // Context is returned in v0. It replaces the context passed to us. 222 // Context is returned in v0. It replaces the context passed to us.
222 // It's saved in the stack and kept live in cp. 223 // It's saved in the stack and kept live in cp.
223 __ mov(cp, v0); 224 __ mov(cp, v0);
224 __ sw(v0, MemOperand(fp, StandardFrameConstants::kContextOffset)); 225 __ sw(v0, MemOperand(fp, StandardFrameConstants::kContextOffset));
225 // Copy any necessary parameters into the context. 226 // Copy any necessary parameters into the context.
226 int num_parameters = info->scope()->num_parameters(); 227 int num_parameters = info->scope()->num_parameters();
227 for (int i = 0; i < num_parameters; i++) { 228 int first_parameter = info->scope()->has_this_declaration() ? -1 : 0;
228 Variable* var = scope()->parameter(i); 229 for (int i = first_parameter; i < num_parameters; i++) {
230 Variable* var = (i == -1) ? scope()->receiver() : scope()->parameter(i);
229 if (var->IsContextSlot()) { 231 if (var->IsContextSlot()) {
230 int parameter_offset = StandardFrameConstants::kCallerSPOffset + 232 int parameter_offset = StandardFrameConstants::kCallerSPOffset +
231 (num_parameters - 1 - i) * kPointerSize; 233 (num_parameters - 1 - i) * kPointerSize;
232 // Load parameter from stack. 234 // Load parameter from stack.
233 __ lw(a0, MemOperand(fp, parameter_offset)); 235 __ lw(a0, MemOperand(fp, parameter_offset));
234 // Store it in the context. 236 // Store it in the context.
235 MemOperand target = ContextOperand(cp, var->index()); 237 MemOperand target = ContextOperand(cp, var->index());
236 __ sw(a0, target); 238 __ sw(a0, target);
237 239
238 // Update the write barrier. 240 // Update the write barrier.
(...skipping 5109 matching lines...) Expand 10 before | Expand all | Expand 10 after
5348 Assembler::target_address_at(pc_immediate_load_address)) == 5350 Assembler::target_address_at(pc_immediate_load_address)) ==
5349 reinterpret_cast<uint32_t>( 5351 reinterpret_cast<uint32_t>(
5350 isolate->builtins()->OsrAfterStackCheck()->entry())); 5352 isolate->builtins()->OsrAfterStackCheck()->entry()));
5351 return OSR_AFTER_STACK_CHECK; 5353 return OSR_AFTER_STACK_CHECK;
5352 } 5354 }
5353 5355
5354 5356
5355 } } // namespace v8::internal 5357 } } // namespace v8::internal
5356 5358
5357 #endif // V8_TARGET_ARCH_MIPS 5359 #endif // V8_TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698