Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 883813002: [Chromoting] Fix broken OK/Cancel button in loading window. (Closed)

Created:
5 years, 11 months ago by garykac
Modified:
5 years, 11 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Fix broken OK/Cancel button in loading window. The recent change to add jscompile annotations include a change that breaks that default OK/Cancel button of the loading window (because of the number -> string conversion). This cl removes the conversion that was added and and updates the type annotation for sendReply_ to address the jscompile warning. NOTRY=True BUG= Committed: https://crrev.com/01fdbfdf971a9f1d61652bcc181cc4c6790bc79d Cr-Commit-Position: refs/heads/master@{#313327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M remoting/webapp/base/js/message_window.js View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
garykac
5 years, 11 months ago (2015-01-27 18:11:40 UTC) #2
Jamie
lgtm
5 years, 11 months ago (2015-01-27 19:42:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883813002/1
5 years, 11 months ago (2015-01-27 19:47:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 19:49:14 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 19:50:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01fdbfdf971a9f1d61652bcc181cc4c6790bc79d
Cr-Commit-Position: refs/heads/master@{#313327}

Powered by Google App Engine
This is Rietveld 408576698