Make addlatexhash_test clean up its temp directories.

tests/standalone/io/addlatexhash_test.dart

 #!/usr/bin/env dart
 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // testing ../../../tools/addlatexhash.dart
 
 import 'dart:io';
 import 'package:path/path.dart' as path;
 import '../../../tools/addlatexhash.dart';
@@ skipping 41 matching lines @@
   oneTestSisp(sispIsDartBegin, "Begin", "whatever else ..", false);
   oneTestSisp(sispIsDartEnd, "End", "\\end{dartCode}", true);
   oneTestSisp(sispIsDartEnd, "End", " \\end{dartCode}\t  \n", true);
   oneTestSisp(sispIsDartEnd, "End", "whatever else ..", false);
 }
 
 // Check that the hash values of paragraphs in the specially prepared
 // LaTeX source 'addlatexhash_test_src.tex' are identical in groups
 // of eight (so we get 8 identical hash values, then another hash
 // value 8 times, etc.)
-testSameHash() {
-  // set up temporary directory to hold output
-  final tmpDir = Directory.systemTemp.createTempSync("addlatexhash_test");
-  final tmpDirPath = tmpDir.path;
-
+testSameHash(String tmpDirPath) {
   // file names/paths for file containing groups of 8 variants of a paragraph
   const par8timesName = "addlatexhash_test_src";
   const par8timesFileName = "$par8timesName.tex";
   final par8timesDirPath = path.join(dartRootDir, "tests", "standalone", "io");
   final par8timesPath = path.join(par8timesDirPath, par8timesFileName);
   final tmpPar8timesPath = path.join(tmpDirPath, par8timesFileName);
 
   // file names paths for output
   final hashName = par8timesName + "-hash";
   final hashFileName = "$hashName.tex";
@@ skipping 36 matching lines @@
     } else {
       sameCount++;
     }
   }
 }
 
 // Check that the LaTeX source transformation done by addlatexhash.dart
 // does not affect the generated output, as seen via dvi2tty and diff.
 // NB: Not part of normal testing (only local): latex and dvi2tty are
 // not installed in the standard test environment.
-testSameDVI() {
-  // set up /tmp directory to hold output
-  final tmpDir = Directory.systemTemp.createTempSync("addlatexhash_test");
-  final tmpDirPath = tmpDir.path;
-
+testSameDVI(String tmpDirPath) {
   // file names/paths for original spec
   const specName = "dartLangSpec";
   const specFileName = "$specName.tex";
   final specDirPath = path.join(dartRootDir, "docs", "language");
   final specPath = path.join(specDirPath, specFileName);
   final tmpSpecPath = path.join(tmpDirPath, specFileName);
   const specDviFileName = "$specName.dvi";
   final specDviPath = path.join(tmpDirPath, specDviFileName);
 
   // file names/paths for associated sty
@@ skipping 47 matching lines @@
     checkAction(runLatex(hashFileName, tmpDirPath), "LaTeX on output failed");
   }
   if (chkDvi2tty(specDviPath, "spec") != chkDvi2tty(hashDviPath, "output")) {
     throw "dvi2tty spec != dvitty output";
   }
 }
 
 main([args]) {
   testCutMatch();
   testSisp();
-  testSameHash();
+
+  final tmpDir = Directory.systemTemp.createTempSync("addlatexhash_test");
+  try {
+    testSameHash(tmpDir.path);
+  } finally {
+    tmpDir.delete(recursive: true);
+  }
   // latex and dvi2tty are not installed in the standard test environment
-  if (args.length > 0 && args[0] == "local") testSameDVI();
+  if (args.length > 0 && args[0] == "local") {
+    final dviDir = Directory.systemTemp.createTempSync("addlatexhash_test");
+    try {
+      testSameDVI(dviDir.path);
+    } finally {
+      dviDir.delete(recursive: true);
+    }
+  }

[eernst, 2015/01/28 13:04:35]

Ah, of course I should have removed those tmp files.  

But, as a small twist, maybe something like this could be used to keep main
small & readable:

runWithTmpDir(void f(String)) {
  final tmpDir = Directory.systemTemp.createTempSync("addlatexhash_test");
  try {
    f(tmpDir.path);
  }
  finally {
    tmpDir.delete(recursive: true);
  }
}

and then in main:

  runWithTmpDir(testSameHash);
  ..
  if (..) runWithTestDir(testSameDVI);

 }