minidump/minidump_thread_id_map.cc - Issue 883773005: win: Work towards getting 'minidump' to compile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_thread_id_map.cc

Issue 883773005: win: Work towards getting 'minidump' to compile (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@crash-report-db-win

Patch Set: more mucking around Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_thread_id_map.cc

diff --git a/minidump/minidump_thread_id_map.cc b/minidump/minidump_thread_id_map.cc

index 919566f5d05623ee5c73adce29de1b7d76c4b9fe..a6ac6fdd78ac3cb04e5425880a7087f5ba320594 100644

--- a/minidump/minidump_thread_id_map.cc

+++ b/minidump/minidump_thread_id_map.cc

@@ -36,7 +36,7 @@ void BuildMinidumpThreadIDMap(

for (const ThreadSnapshot* thread_snapshot : thread_snapshots) {

uint64_t thread_id_64 = thread_snapshot->ThreadID();

if (thread_id_map->find(thread_id_64) == thread_id_map->end()) {

- uint32_t thread_id_32 = thread_id_64;

+ uint32_t thread_id_32 = static_cast<uint32_t>(thread_id_64);

if (thread_ids_32.find(thread_id_32) != thread_ids_32.end()) {

collision = true;

break;

« no previous file with comments | « minidump/minidump_system_info_writer_test.cc ('k') | minidump/minidump_thread_writer.h » ('j') | no next file with comments »