Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: minidump/minidump_context.h

Issue 883773005: win: Work towards getting 'minidump' to compile (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@crash-report-db-win
Patch Set: more mucking around Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compat/win/sys/types.h ('k') | minidump/minidump_context_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_context.h
diff --git a/minidump/minidump_context.h b/minidump/minidump_context.h
index 9da4c44b534644653548d7f1686de1223d9cde7f..4eb3acfa3cd13aff48502cc4483e70ad6c0c41d1 100644
--- a/minidump/minidump_context.h
+++ b/minidump/minidump_context.h
@@ -17,6 +17,7 @@
#include <stdint.h>
+#include "base/compiler_specific.h"
#include "snapshot/cpu_context.h"
#include "util/numeric/int128.h"
@@ -187,7 +188,7 @@ struct MinidumpContextX86 {
CPUContextX86::Fxsave fxsave;
};
-//! \brief x86_64-specifc flags for MinidumpContextAMD64::context_flags.
+//! \brief x86_64-specific flags for MinidumpContextAMD64::context_flags.
enum MinidumpContextAMD64Flags : uint32_t {
//! \brief Identifies the context structure as x86_64. This is the same as
//! `CONTEXT_AMD64` on Windows for this architecture.
@@ -253,7 +254,7 @@ enum MinidumpContextAMD64Flags : uint32_t {
//! normally alias `dr6` and `dr7`, respectively. See Intel Software
//! Developer’s Manual, Volume 3B: System Programming, Part 2 (253669-052),
//! 17.2.2 “Debug Registers DR4 and DR5”.
-struct __attribute__((aligned(16))) MinidumpContextAMD64 {
+struct ALIGNAS(16) MinidumpContextAMD64 {
//! \brief Register parameter home address.
//!
//! On Windows, this field may contain the “home” address (on-stack, in the
« no previous file with comments | « compat/win/sys/types.h ('k') | minidump/minidump_context_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698