Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: compat/non_win/windows.h

Issue 883773005: win: Work towards getting 'minidump' to compile (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@crash-report-db-win
Patch Set: more mucking around Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compat/compat.gyp ('k') | compat/win/sys/time.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compat/non_win/windows.h
diff --git a/client/crash_report_database.cc b/compat/non_win/windows.h
similarity index 70%
copy from client/crash_report_database.cc
copy to compat/non_win/windows.h
index 0a090b5c2c39b7a85e59e1c595d19daf90ba3384..457745149369eb3149b22bed3141f267a62fe583 100644
--- a/client/crash_report_database.cc
+++ b/compat/non_win/windows.h
@@ -12,13 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "client/crash_report_database.h"
-
-namespace crashpad {
-
-CrashReportDatabase::Report::Report()
- : uuid(), file_path(), id(), creation_time(0), uploaded(false),
- last_upload_attempt_time(0), upload_attempts(0) {
-}
-
-} // namespace crashpad
+// dbghelp.h on Windows requires inclusion of windows.h before it. To avoid
+// cluttering all inclusions of dbghelp.h with #ifdefs, always include windows.h
+// and have an empty one on non-Windows platforms.
« no previous file with comments | « compat/compat.gyp ('k') | compat/win/sys/time.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698