win: Work towards getting 'minidump' to compile

snapshot/process_snapshot.h

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #ifndef CRASHPAD_SNAPSHOT_PROCESS_SNAPSHOT_H_
 #define CRASHPAD_SNAPSHOT_PROCESS_SNAPSHOT_H_
 
+#include "build/build_config.h"
+
+#include <sys/types.h>
+
+#if defined(OS_WIN)
+#include <windows.h>
+#include <winsock2.h>

[Mark Mentovai, 2015/02/02 22:10:28]

What for, timeval?

(Just for clarification. I don’t mean to add a comment for this, because the “//
for struct foo” definitions people sometimes add get stale very quickly.)

[scottmg, 2015/02/02 22:31:45]

Right. It would probably be reasonable to add a compat/win/sys/time.h containing

struct timeval {
        long    tv_sec;         /* seconds */
        long    tv_usec;        /* and microseconds */
};


to avoid pulling in so much goop for so little.

[Mark Mentovai, 2015/02/02 22:57:21]

scottmg wrote:
Let’s do that, then.

+#else
 #include <sys/time.h>
-#include <sys/types.h>
+#endif
 
 #include <vector>
 
 namespace crashpad {
 
 class ExceptionSnapshot;
 class ModuleSnapshot;
 class SystemSnapshot;
 class ThreadSnapshot;
 
@@ skipping 76 matching lines @@
   //! \return An ExceptionSnapshot object. The caller does not take ownership of
   //!     this object, it is scoped to the lifetime of the ProcessSnapshot
   //!     object that it was obtained from. If the snapshot is not a result of
   //!     an exception, returns `nullptr`.
   virtual const ExceptionSnapshot* Exception() const = 0;
 };
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_SNAPSHOT_PROCESS_SNAPSHOT_H_