win: Work towards getting 'minidump' to compile

minidump/minidump_extensions.h

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #ifndef CRASHPAD_MINIDUMP_MINIDUMP_EXTENSIONS_H_
 #define CRASHPAD_MINIDUMP_MINIDUMP_EXTENSIONS_H_
 
-#include <dbghelp.h>
 #include <stdint.h>
-#include <winnt.h>
 
+#include "base/compiler_specific.h"
+#include "build/build_config.h"
+#include "minidump/crashpad_dbghelp.h"
+#include "minidump/crashpad_winnt.h"
 #include "util/misc/uuid.h"
 
+#if defined(COMPILER_MSVC)
+#define PACKED
+#pragma pack(push, 1)

[Mark Mentovai, 2015/02/03 18:26:32]

This is going to suck if we want a non-packed struct in here, but that should
hopefully never happen.

[scottmg, 2015/02/03 19:22:44]

Agreed.

+#else
+#define PACKED __attribute((packed))
+#endif  // COMPILER_MSVC
+
 namespace crashpad {
 
 //! \brief Minidump stream type values for MINIDUMP_DIRECTORY::StreamType. Each
 //!     stream structure has a corresponding stream type value to identify it.
 //!
 //! \sa MINIDUMP_STREAM_TYPE
 enum MinidumpStreamType : uint32_t {
   //! \brief The stream type for MINIDUMP_THREAD_LIST.
   //!
   //! \sa ThreadListStream
@@ skipping 28 matching lines @@
   // 0x4350 = "CP"
 
   //! \brief The stream type for MinidumpCrashpadInfo.
   kMinidumpStreamTypeCrashpadInfo = 0x43500001,
 };
 
 //! \brief A variable-length UTF-8-encoded string carried within a minidump
 //!     file.
 //!
 //! \sa MINIDUMP_STRING
-struct __attribute__((packed, aligned(4))) MinidumpUTF8String {
+struct ALIGNAS(4) PACKED MinidumpUTF8String {
   // The field names do not conform to typical style, they match the names used
   // in MINIDUMP_STRING. This makes it easier to operate on MINIDUMP_STRING (for
   // UTF-16 strings) and MinidumpUTF8String using templates.
 
   //! \brief The length of the #Buffer field in bytes, not including the `NUL`
   //!     terminator.
   //!
   //! \note This field is interpreted as a byte count, not a count of Unicode
   //!     code points.
   uint32_t Length;
@@ skipping 207 matching lines @@
   //! \brief The path or file name of the `.pdb` file associated with the
   //!     module.
   //!
   //! This is a NUL-terminated string. On Windows, it will be encoded in the
   //! code page of the system that linked the module. On other operating
   //! systems, UTF-8 may be used.
   uint8_t pdb_name[1];
 };
 
 //! \brief A list of ::RVA pointers.
-struct __attribute__((packed, aligned(4))) MinidumpRVAList {
+struct ALIGNAS(4) PACKED MinidumpRVAList {
   //! \brief The number of children present in the #children array.
   uint32_t count;
 
   //! \brief Pointers to other structures in the minidump file.
   RVA children[0];
-};
+);

[Mark Mentovai, 2015/02/03 18:26:32]

Make this a } again.

 
 //! \brief A list of MINIDUMP_LOCATION_DESCRIPTOR objects.
-struct __attribute__((packed, aligned(4))) MinidumpLocationDescriptorList {
+struct ALIGNAS(4) PACKED MinidumpLocationDescriptorList {
   //! \brief The number of children present in the #children array.
   uint32_t count;
 
   //! \brief Pointers to other structures in the minidump file.
   MINIDUMP_LOCATION_DESCRIPTOR children[0];
 };
 
 //! \brief A key-value pair.
-struct __attribute__((packed, aligned(4))) MinidumpSimpleStringDictionaryEntry {
+struct ALIGNAS(4) PACKED MinidumpSimpleStringDictionaryEntry {
   //! \brief ::RVA of a MinidumpUTF8String containing the key of a key-value
   //!     pair.
   RVA key;
 
   //! \brief ::RVA of a MinidumpUTF8String containing the value of a key-value
   //!     pair.
   RVA value;
 };
 
 //! \brief A list of key-value pairs.
-struct __attribute__((packed, aligned(4))) MinidumpSimpleStringDictionary {
+struct ALIGNAS(4) PACKED MinidumpSimpleStringDictionary {
   //! \brief The number of key-value pairs present.
   uint32_t count;
 
   //! \brief A list of MinidumpSimpleStringDictionaryEntry entries.
   MinidumpSimpleStringDictionaryEntry entries[0];
 };
 
 //! \brief Additional Crashpad-specific information about a module carried
 //!     within a minidump file.
 //!
 //! This structure augments the information provided by MINIDUMP_MODULE. The
 //! minidump file must contain a module list stream
 //! (::kMinidumpStreamTypeModuleList) in order for this structure to appear.
 //!
 //! This structure is versioned. When changing this structure, leave the
 //! existing structure intact so that earlier parsers will be able to understand
 //! the fields they are aware of, and make additions at the end of the
 //! structure. Revise #kVersion and document each field’s validity based on
 //! #version, so that newer parsers will be able to determine whether the added
 //! fields are valid or not.
 //!
 //! \sa #MinidumpModuleCrashpadInfoList
-struct __attribute__((packed, aligned(4))) MinidumpModuleCrashpadInfo {
+struct ALIGNAS(4) PACKED MinidumpModuleCrashpadInfo {
   //! \brief The structure’s currently-defined version number.
   //!
   //! \sa version
   static const uint32_t kVersion = 1;
 
   //! \brief The structure’s version number.
   //!
   //! Readers can use this field to determine which other fields in the
   //! structure are valid. Upon encountering a value greater than #kVersion, a
   //! reader should assume that the structure’s layout is compatible with the
@@ skipping 52 matching lines @@
 
 //! \brief Additional Crashpad-specific information carried within a minidump
 //!     file.
 //!
 //! This structure is versioned. When changing this structure, leave the
 //! existing structure intact so that earlier parsers will be able to understand
 //! the fields they are aware of, and make additions at the end of the
 //! structure. Revise #kVersion and document each field’s validity based on
 //! #version, so that newer parsers will be able to determine whether the added
 //! fields are valid or not.
-struct __attribute__((packed, aligned(4))) MinidumpCrashpadInfo {
+struct ALIGNAS(4) PACKED MinidumpCrashpadInfo {
   //! \brief The structure’s currently-defined version number.
   //!
   //! \sa version
   static const uint32_t kVersion = 1;
 
   //! \brief The structure’s version number.
   //!
   //! Readers can use this field to determine which other fields in the
   //! structure are valid. Upon encountering a value greater than #kVersion, a
   //! reader should assume that the structure’s layout is compatible with the
   //! structure defined as having value #kVersion.
   //!
   //! Writers may produce values less than #kVersion in this field if there is
   //! no need for any fields present in later versions.
   uint32_t version;
 
   //! \brief A pointer to a #MinidumpModuleCrashpadInfoList structure.
   //!
   //! This field is present when #version is at least `1`.
   MINIDUMP_LOCATION_DESCRIPTOR module_list;
 };
 
+#if defined(COMPILER_MSVC)
+#pragma pack(pop)
+#endif  // COMPILER_MSVC
+#undef PACKED
+
 }  // namespace crashpad
 
 #endif  // CRASHPAD_MINIDUMP_MINIDUMP_EXTENSIONS_H_