Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 883773004: Added a module for the Presentation API under public/platform (Closed)

Created:
5 years, 10 months ago by whywhat
Modified:
5 years, 10 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Added a module for the Presentation API under public/platform Just copied the files over and updated the references in Blink. Will update the references in Chromium and remove the files from public/platform later. Chromium CL: https://codereview.chromium.org/889913002 Deleting the old files CL: https://codereview.chromium.org/890923002 BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189259

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed OWNERS in Source/modules/presentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/modules/presentation/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/presentation/PresentationController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/presentation/PresentationController.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + public/platform/modules/presentation/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + public/platform/modules/presentation/WebPresentationClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/presentation/WebPresentationController.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
whywhat
PTAL
5 years, 10 months ago (2015-01-30 12:39:39 UTC) #2
Mike West
Jochen, did anyone object to the public/platform/modules notion?
5 years, 10 months ago (2015-01-30 12:41:33 UTC) #5
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/883773004/diff/1/public/platform/modules/presentation/OWNERS File public/platform/modules/presentation/OWNERS (right): https://codereview.chromium.org/883773004/diff/1/public/platform/modules/presentation/OWNERS#newcode2 public/platform/modules/presentation/OWNERS:2: imcheng@chromium.org why does the file differ from the ...
5 years, 10 months ago (2015-01-30 12:51:17 UTC) #7
whywhat
https://codereview.chromium.org/883773004/diff/1/public/platform/modules/presentation/OWNERS File public/platform/modules/presentation/OWNERS (right): https://codereview.chromium.org/883773004/diff/1/public/platform/modules/presentation/OWNERS#newcode2 public/platform/modules/presentation/OWNERS:2: imcheng@chromium.org On 2015/01/30 12:51:17, jochen (slow) wrote: > why ...
5 years, 10 months ago (2015-01-30 12:54:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883773004/20001
5 years, 10 months ago (2015-01-30 13:11:49 UTC) #10
Mike West
LGTM. Before landing this, would you mind uploading the subsequent patches, and updating the CL ...
5 years, 10 months ago (2015-01-30 13:24:21 UTC) #11
whywhat
On 2015/01/30 13:24:21, Mike West wrote: > LGTM. Before landing this, would you mind uploading ...
5 years, 10 months ago (2015-01-30 13:51:06 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 15:38:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189259

Powered by Google App Engine
This is Rietveld 408576698