Fix missing .Pass() on returning scoped_ptr<SdchManager::DictionarySet>

net/base/sdch_manager.cc

Index: net/base/sdch_manager.cc
diff --git a/net/base/sdch_manager.cc b/net/base/sdch_manager.cc
index 05787f328c1029f08cd6d3e4afe7ef39f5ec5083..27d86ee858f61e581c2197dca5edfe62eb2e2ea5 100644
--- a/net/base/sdch_manager.cc
+++ b/net/base/sdch_manager.cc
@@ -456,15 +456,15 @@ SdchManager::GetDictionarySetByHash(
   *problem_code = SDCH_DICTIONARY_HASH_NOT_FOUND;
   const auto& it = dictionaries_.find(server_hash);
   if (it == dictionaries_.end())
-    return result;
+    return result.Pass();

[jamesr, 2015/01/27 23:40:13]

hmm, this should be an xvalue and thus not require a .Pass().  Have you filed an
msdn bug?

[scottmg, 2015/01/27 23:42:10]

Sorry, I don't fully understand those words as well as I ought to. This
http://www.chromium.org/developers/smart-pointer-guidelines is incorrect now
then for C++11?

[Nico, 2015/01/27 23:51:32]

jamesr: I think this is correct. This doesn't build either:
#include <memory>

std::unique_ptr<int> GetInt(bool b) {
  std::unique_ptr<int> result;
  if (b)
    return result;
  return result;
}
Mith msvs2015, does that error too? It probably does. One has to std::move() the
returned unique_ptr. So it makes sense to me that one has to .Pass() a
scoped_ptr. (written in 1 minute without much research tho)

[jamesr, 2015/01/27 23:57:24]

come to think of it, why aren't these just "return nullptr" ?  maybe NRVO is
messing this up.

what do msvs2013/2015 do with this:

std::unique_ptr<int> GetInt(bool b) {
  std::unique_ptr<int> one;
  std::unique_ptr<int> two;
  if (b)
    return one;
  return two;
}

?

 
   *problem_code = it->second->data.CanUse(target_url);
   if (*problem_code != SDCH_OK)
-    return result;
+    return result.Pass();
 
   result.reset(new DictionarySet);
   result->AddDictionary(it->first, it->second);
-  return result;
+  return result.Pass();
 }
 
 // static