chrome/browser/services/gcm/push_messaging_service_impl.h - Issue 883743002: Push API: Grace - allow one in ten pushes to show no notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/push_messaging_service_impl.h

Issue 883743002: Push API: Grace - allow one in ten pushes to show no notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@userdata

Patch Set: Fix typo (invesed needed but not shown logic) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/services/gcm/push_messaging_browsertest.cc ('k') | chrome/browser/services/gcm/push_messaging_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/push_messaging_service_impl.h

diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.h b/chrome/browser/services/gcm/push_messaging_service_impl.h

index f09674e9eec06c93ce31fcae5e2f4794723b24c2..9cc53c08b73d2b11ba3168ee531d8b7b0c2f0397 100644

--- a/chrome/browser/services/gcm/push_messaging_service_impl.h

+++ b/chrome/browser/services/gcm/push_messaging_service_impl.h

@@ -87,6 +87,13 @@ class PushMessagingServiceImpl : public content::PushMessagingService,

// happened in the background. When they forget to do so, display a default

// notification on their behalf.

void RequireUserVisibleUX(const PushMessagingApplicationId& application_id);

+ void DidGetNotificationsShown(

+ const PushMessagingApplicationId& application_id,

+ bool notification_shown,

+ bool notification_needed,

+ const std::string& data,

+ bool success,

+ bool not_found);

void RegisterEnd(

const content::PushMessagingService::RegisterCallback& callback,