Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 883703004: Move chrome.diagnostics API to extensions/. (Closed)

Created:
5 years, 10 months ago by babu
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move chrome.diagnostics API to extensions/. Move the chrome.diagnostics extension API from chrome/ to extensions/. BUG=395240 Committed: https://crrev.com/beafd8cb70f31a44502a9040af396b8cd61dcdb1 Cr-Commit-Position: refs/heads/master@{#314338}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -296 lines) Patch
D chrome/browser/extensions/api/diagnostics/diagnostics_api.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/extensions/api/diagnostics/diagnostics_api.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/extensions/api/diagnostics/diagnostics_api_chromeos.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/common/extensions/api/diagnostics.idl View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + extensions/browser/api/diagnostics/diagnostics_api.h View 3 chunks +6 lines, -8 lines 0 comments Download
A + extensions/browser/api/diagnostics/diagnostics_api.cc View 2 chunks +8 lines, -7 lines 0 comments Download
A + extensions/browser/api/diagnostics/diagnostics_api_chromeos.cc View 4 chunks +10 lines, -15 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 1 chunk +15 lines, -0 lines 0 comments Download
A + extensions/common/api/diagnostics.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
babu
5 years, 10 months ago (2015-02-02 15:08:16 UTC) #2
Lei Zhang
chrome/ lgtm
5 years, 10 months ago (2015-02-02 19:51:54 UTC) #3
Yoyo Zhou
LGTM
5 years, 10 months ago (2015-02-02 21:35:01 UTC) #4
James Cook
LGTM
5 years, 10 months ago (2015-02-02 22:35:57 UTC) #5
babu
Thanks all for reviewing!
5 years, 10 months ago (2015-02-03 12:43:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883703004/1
5 years, 10 months ago (2015-02-03 12:45:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja_ng/builds/6752)
5 years, 10 months ago (2015-02-03 12:47:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883703004/20001
5 years, 10 months ago (2015-02-03 14:29:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 15:16:55 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 15:18:08 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/beafd8cb70f31a44502a9040af396b8cd61dcdb1
Cr-Commit-Position: refs/heads/master@{#314338}

Powered by Google App Engine
This is Rietveld 408576698