Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

Issue 883703002: dart2js: Not all interceptor accesses are safe. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
index 98691d20edd98b90c6aa0cf5e4a3cd14f7a17bf7..a543208cb2a1265976f8a1e35b15227dbc561618 100644
--- a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
@@ -128,9 +128,10 @@ class Emitter implements emitterTask.Emitter {
}
@override
- js.PropertyAccess interceptorClassAccess(ClassElement element) {
- // Interceptors are eagerly constructed. It's safe to just access them.
- return _globalPropertyAccess(element);
+ js.Expression interceptorClassAccess(ClassElement element) {
+ // Some interceptors are eagerly constructed. However, native interceptors
+ // aren't.
+ return js.js('#.ensureResolved()', _globalPropertyAccess(element));
}
@override
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698