Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 883653002: Change kInvalidMediaPlayerID to const (Closed)

Created:
5 years, 11 months ago by william.xie1
Modified:
5 years ago
Reviewers:
qinmin
CC:
chromium-reviews, darin-cc_chromium.org, jam, avayvod+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor Refactor: Define kInvalidMediaPlayerID to replace "-1" for BrowserMediaPlayerManager BUG= Committed: https://crrev.com/d5c76bdc2a7ff06c0beca1bfd86ed1ba682491a4 Cr-Commit-Position: refs/heads/master@{#313407}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M content/browser/media/android/browser_media_player_manager.cc View 1 6 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
william.xie1
PTAL
5 years, 11 months ago (2015-01-27 09:22:21 UTC) #2
Hugo Holgersson
On 2015/01/27 09:22:21, william.xie wrote: > PTAL Sorry for nits: - I think CL title ...
5 years, 11 months ago (2015-01-27 13:46:41 UTC) #3
qinmin
lgtm % nit https://codereview.chromium.org/883653002/diff/1/content/browser/media/android/browser_media_player_manager.cc File content/browser/media/android/browser_media_player_manager.cc (right): https://codereview.chromium.org/883653002/diff/1/content/browser/media/android/browser_media_player_manager.cc#newcode42 content/browser/media/android/browser_media_player_manager.cc:42: const int kInvalidMediaPlayerID = -1; nit:/ID/Id/
5 years, 11 months ago (2015-01-27 22:42:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883653002/20001
5 years, 11 months ago (2015-01-27 22:56:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 23:56:31 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 23:57:52 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d5c76bdc2a7ff06c0beca1bfd86ed1ba682491a4
Cr-Commit-Position: refs/heads/master@{#313407}

Powered by Google App Engine
This is Rietveld 408576698