Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 883603002: Rename StreamlinedHostedApps to NewBookmarkApps in the code. (Closed)

Created:
5 years, 10 months ago by benwells
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, sadrul, kalyank, chrome-apps-syd-reviews_chromium.org, tfarina, arv+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename StreamlinedHostedApps to NewBookmarkApps in the code. This feature is now known by the name 'bookmark apps'. BUG=441127 Committed: https://crrev.com/c431c0aee04d6b2caa3112f9d5b8b8682e69aa91 Cr-Commit-Position: refs/heads/master@{#313370}

Patch Set 1 #

Patch Set 2 : Ran git cl format #

Patch Set 3 : Comments and variables #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -69 lines) Patch
M chrome/browser/extensions/api/management/chrome_management_api_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/chrome_management_api_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_util.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/launch_util.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/apps_page.js View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/app_context_menu.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc View 1 2 2 chunks +5 lines, -6 lines 1 comment Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/renderer/web_apps.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/management/management_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/management/management_api_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
https://codereview.chromium.org/883603002/diff/40001/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc File chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc (left): https://codereview.chromium.org/883603002/diff/40001/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc#oldcode70 chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc:70: // apps flag isn't available on Mac, so we ...
5 years, 10 months ago (2015-01-27 10:39:36 UTC) #2
Lei Zhang
lgtm
5 years, 10 months ago (2015-01-27 20:20:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883603002/40001
5 years, 10 months ago (2015-01-27 21:09:43 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-27 22:04:37 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 22:05:52 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c431c0aee04d6b2caa3112f9d5b8b8682e69aa91
Cr-Commit-Position: refs/heads/master@{#313370}

Powered by Google App Engine
This is Rietveld 408576698