Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 883583005: Copy build changes to compile mojo::AsyncWaiter to the chromium repo. (Closed)

Created:
5 years, 10 months ago by Sam McNally
Modified:
5 years, 10 months ago
Reviewers:
jamesr, viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy build changes to compile mojo::AsyncWaiter to the chromium repo. mojo::AsyncWaiter was added to mojo/public/cpp/environment in https://github.com/domokit/mojo/commit/2b6c27fbbe9b704a77e977615b945f364bf520ca and was rolled into chromium. However, the chromium environment implementation is on mojo/environment, which is maintained independently of the version in the mojo repo. This CL copies the mojo repo's mojo/environment into the chromium repo so that mojo::AsyncWaiter is usable there. Committed: https://crrev.com/b02c427dcb9f3cfa5c84ec685e0f1d52cd8fba9f Cr-Commit-Position: refs/heads/master@{#313859}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M mojo/environment/BUILD.gn View 1 3 chunks +12 lines, -1 line 0 comments Download
M mojo/environment/default_run_loop_impl.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M mojo/mojo_base.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Sam McNally
5 years, 10 months ago (2015-01-29 03:31:39 UTC) #2
jamesr
Please roll everything together - patching things piecewise in the chromium repo makes it really ...
5 years, 10 months ago (2015-01-29 20:11:01 UTC) #3
Sam McNally
On 2015/01/29 20:11:01, jamesr wrote: > Please roll everything together - patching things piecewise in ...
5 years, 10 months ago (2015-01-29 23:43:15 UTC) #4
jamesr
Oh - sorry I was confused. This isn't a roll at all, this is code ...
5 years, 10 months ago (2015-01-29 23:44:38 UTC) #6
viettrungluu
LGTM, but: * "However, //mojo/environment:chromium is where the files in mojo/public/cpp/environment are built, and mojo/environment ...
5 years, 10 months ago (2015-01-30 00:05:33 UTC) #7
Sam McNally
Updated the description to hopefully be clearer/more correct. jamesr: PTAL
5 years, 10 months ago (2015-01-30 01:47:18 UTC) #8
jamesr
lgtm
5 years, 10 months ago (2015-01-30 02:13:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883583005/20001
5 years, 10 months ago (2015-01-30 02:17:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 02:21:03 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 02:21:51 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b02c427dcb9f3cfa5c84ec685e0f1d52cd8fba9f
Cr-Commit-Position: refs/heads/master@{#313859}

Powered by Google App Engine
This is Rietveld 408576698