Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 883553002: A better fix for crash when opening Incognito window. (Closed)

Created:
5 years, 11 months ago by Andre
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek, Finnur, sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ValidationMessageBubble
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A better fix for crash when opening Incognito window. A better fix for https://codereview.chromium.org/822083004/. Set kServiceRedirectedInIncognito so that ExtensionCommandsGlobalRegistry::Get does not return null on incognito profiles, and remove null checks that are no longer necessary. BUG=450903 Committed: https://crrev.com/d23af8f121147bdced97b13fa7518b19050447d6 Cr-Commit-Position: refs/heads/master@{#313393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M chrome/browser/extensions/extension_commands_global_registry.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Finnur
LGTM. Thanks! > so I thought you were wanting to call set_registry_for_active_window() with the incognito ...
5 years, 11 months ago (2015-01-27 10:10:12 UTC) #2
Andre
+rsesek for cocoa/ +sky for views/
5 years, 11 months ago (2015-01-27 16:24:36 UTC) #4
Robert Sesek
cocoa/ LGTM stamp
5 years, 11 months ago (2015-01-27 17:52:27 UTC) #5
sky
LGTM
5 years, 10 months ago (2015-01-27 21:48:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883553002/1
5 years, 10 months ago (2015-01-27 23:06:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-27 23:11:05 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 23:12:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d23af8f121147bdced97b13fa7518b19050447d6
Cr-Commit-Position: refs/heads/master@{#313393}

Powered by Google App Engine
This is Rietveld 408576698