Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: client/html/src/Measurement.dart

Issue 8835006: New version of dart:html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix typos Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/src/GlobalProperties.dart ('k') | client/html/src/SVGDocument.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/html/src/Measurement.dart
diff --git a/client/html/src/Measurement.dart b/client/html/src/Measurement.dart
index dfcf40a2826194dc02d7afeee8b099cf04dd46fa..e92a46c82b7d82ebd44be89fded51e59a5e56b91 100644
--- a/client/html/src/Measurement.dart
+++ b/client/html/src/Measurement.dart
@@ -86,12 +86,14 @@ void _completeMeasurementFutures() {
// We must compute all new values before fulfilling the futures as
// the onComplete callbacks for the futures could modify the DOM making
// subsequent measurement calculations expensive to compute.
- for (_MeasurementRequest request in _pendingRequests) {
- try {
- request.value = request.computeValue();
- } catch(var e) {
- request.value = e;
- request.exception = true;
+ if (_pendingRequests !== null) {
+ for (_MeasurementRequest request in _pendingRequests) {
+ try {
+ request.value = request.computeValue();
+ } catch(var e) {
+ request.value = e;
+ request.exception = true;
+ }
}
}
@@ -99,11 +101,13 @@ void _completeMeasurementFutures() {
final readyMeasurementFrameCallbacks = _pendingMeasurementFrameCallbacks;
_pendingRequests = null;
_pendingMeasurementFrameCallbacks = null;
- for (_MeasurementRequest request in completedRequests) {
- if (request.exception) {
- request.completer.completeException(request.value);
- } else {
- request.completer.complete(request.value);
+ if (completedRequests !== null) {
+ for (_MeasurementRequest request in completedRequests) {
+ if (request.exception) {
+ request.completer.completeException(request.value);
+ } else {
+ request.completer.complete(request.value);
+ }
}
}
« no previous file with comments | « client/html/src/GlobalProperties.dart ('k') | client/html/src/SVGDocument.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698