Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 883443005: ozone: Add missing dependencies to build (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Add missing dependencies to build These dependencies are needed to enable strict checking of undefied symbols in the shared_library build. BUG=445627 TEST=build chrome for link_freon via simplechrome Committed: https://crrev.com/1677c01e77c0f5719ecc0d8b9aae2ca34db28a86 Cr-Commit-Position: refs/heads/master@{#314421}

Patch Set 1 #

Patch Set 2 : update GN build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M ui/events/ozone/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/gpu/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/gpu/ozone_gpu.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/caca/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/caca/caca.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/dri/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/egltest/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/egltest/egltest.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/test/test.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
spang
5 years, 10 months ago (2015-02-03 21:10:11 UTC) #2
dnicoara
lgtm
5 years, 10 months ago (2015-02-03 21:13:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883443005/20001
5 years, 10 months ago (2015-02-03 21:55:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 22:31:46 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 22:33:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1677c01e77c0f5719ecc0d8b9aae2ca34db28a86
Cr-Commit-Position: refs/heads/master@{#314421}

Powered by Google App Engine
This is Rietveld 408576698