Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 883443003: Remove PseudoId. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove PseudoId. Sky doesn't have pseudo elements (::before, ::after, etc.) R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/96c81213f9d12910556b418ac5ad174183562fd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -66 lines) Patch
M sky/engine/core/css/CSSComputedStyleDeclaration.h View 3 chunks +3 lines, -4 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 6 chunks +6 lines, -9 lines 0 comments Download
M sky/engine/core/css/CSSSelector.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSSelector.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M sky/engine/core/css/resolver/MatchedPropertiesCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Element.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/Node.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/frame/Window.idl View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-26 21:44:02 UTC) #2
esprehn
5 years, 11 months ago (2015-01-26 21:52:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96c81213f9d12910556b418ac5ad174183562fd2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698