Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 88343002: Increase test runner speed. (Closed)

Created:
7 years ago by Michael Achenbach
Modified:
7 years ago
Reviewers:
Yang
CC:
v8-dev, Jakob Kummerow
Visibility:
Public.

Description

Increase test runner speed. Let the test runner preserve the order of test suites to let suites with long running tests run first. Mark some tests as slow that can now be skipped via --slow-tests=skip. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18086

Patch Set 1 #

Total comments: 1

Patch Set 2 : Mark all Threading tests as slow. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M test/cctest/cctest.status View 1 2 chunks +14 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +13 lines, -1 line 0 comments Download
M tools/run-tests.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
7 years ago (2013-11-26 13:44:27 UTC) #1
Yang
LGTM with comment. https://codereview.chromium.org/88343002/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/88343002/diff/1/test/cctest/cctest.status#newcode67 test/cctest/cctest.status:67: 'test-api/Threading4': [PASS, ['mode == debug', SLOW]], ...
7 years ago (2013-11-26 15:52:29 UTC) #2
Michael Achenbach
Committed patchset #2 manually as r18086 (presubmit successful).
7 years ago (2013-11-26 16:53:11 UTC) #3
Michael Achenbach
7 years ago (2013-11-26 16:53:57 UTC) #4
Message was sent while issue was closed.
I marked them all.

Powered by Google App Engine
This is Rietveld 408576698