Parsing of encoded duration for unencrypted opus streams.

media/formats/webm/opus_packet_builder.h

Index: media/formats/webm/opus_packet_builder.h
diff --git a/media/formats/webm/opus_packet_builder.h b/media/formats/webm/opus_packet_builder.h
new file mode 100644
index 0000000000000000000000000000000000000000..f9bf961f07339e577b207943dfd8867f81c5a736
--- /dev/null
+++ b/media/formats/webm/opus_packet_builder.h
@@ -0,0 +1,33 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[wolenetz, 2015/02/03 22:47:01]

s/2012/2015/

[chcunningham, 2015/02/05 02:48:21]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_FORMATS_WEBM_OPUS_PACKET_BUILDER_H_
+#define MEDIA_FORMATS_WEBM_OPUS_PACKET_BUILDER_H_
+
+#include <vector>
+
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
+
+namespace media {
+
+struct OpusPacketInfo {
+  OpusPacketInfo();
+  ~OpusPacketInfo();
+
+  std::vector<uint8> data;

[wolenetz, 2015/02/03 22:47:01]

_t (here and elsewhere, s/uint8/uint8_t/ and similar for 16 or whatever. See
current chromium style guide for this.) As always, if modifying a file that uses
older style, either fix older->newer or just be consistent with older. It looks
on quick inspection that most/all of this CL touches files that didn't
previously use a specific-width type.
Note: I might not have commented on all instances, so please do the needed here.
THanks!

[chcunningham, 2015/02/05 02:48:21]

Done.

+  double duration_ms;
+  int toc_config;
+  int frame_count;
+};
+
+scoped_ptr<OpusPacketInfo> BuildOpusPacket(int config,
+                                           int frame_count,
+                                           bool is_VBR);
+
+std::vector<scoped_ptr<OpusPacketInfo>> BuildAllOpusPackets();

[wolenetz, 2015/02/03 22:47:01]

This is dangerous. See "I want to use an STL container to hold pointers.  Can I
use smart pointers?" at
http://www.chromium.org/developers/smart-pointer-guidelines

Use ScopedVector? Or just return a vector of raw pointers and clean up
manually...

[chcunningham, 2015/02/05 02:48:21]

Done. ScopedVector!

+
+}  // namespace media
+
+#endif  // MEDIA_FORMATS_WEBM_OPUS_PACKET_BUILDER_H_