Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 883393007: Kill off some dodgy JS callbacks (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Kill off some dodgy JS callbacks None of these are currently reachable because the IsSafeMode method always returns true. This, in turn, will let us kill off some file (as in fopen()) based parsing. That, in turn, will let us kill of some more now-unreachable code. In general, we don't want to have unsafe modes. BUG=https://code.google.com/p/pdfium/issues/detail?id=116 R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c6ab1725213a487838cbe03cb08cb5cac4ad956a

Patch Set 1 #

Patch Set 2 : remove more now-unreachable code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -1097 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +3 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 2 chunks +10 lines, -48 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 chunk +0 lines, -6 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 22 chunks +34 lines, -49 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Object.h View 9 chunks +10 lines, -12 lines 0 comments Download
M fpdfsdk/include/javascript/app.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 4 chunks +0 lines, -84 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 47 chunks +74 lines, -624 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 1 38 chunks +84 lines, -239 lines 0 comments Download
M fpdfsdk/src/javascript/report.cpp View 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
John, please review.
5 years, 10 months ago (2015-02-05 22:25:45 UTC) #2
jam
lgtm
5 years, 10 months ago (2015-02-05 23:08:18 UTC) #3
Tom Sepez
5 years, 10 months ago (2015-02-05 23:27:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c6ab1725213a487838cbe03cb08cb5cac4ad956a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698