Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 883373002: Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (Closed)

Created:
5 years, 10 months ago by inferno
Modified:
5 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (patchset #3 id:40001 of https://codereview.chromium.org/725733002/) Reason for revert: Broke ipc fuzzer Original issue's description: > IPC::ChannelMojo: Make IPC handling robust against bad messages. > > This change replaces some DCHECK()s with real error handling. > They happen when it receives broken messages. > > BUG=428800 > R=viettrungluu@chromium.org > > Committed: https://crrev.com/185ffdf58f85e47db9666d2ad9b80ff9bd7fa54b > Cr-Commit-Position: refs/heads/master@{#304102} TBR=viettrungluu@chromium.org,morrita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=428800 Committed: https://crrev.com/726621f93d2802dfc2c90732c7133145c9854e38 Cr-Commit-Position: refs/heads/master@{#313778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M ipc/mojo/ipc_mojo_bootstrap.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
inferno
Created Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages.
5 years, 10 months ago (2015-01-29 20:34:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883373002/1
5 years, 10 months ago (2015-01-29 20:35:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 20:37:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/726621f93d2802dfc2c90732c7133145c9854e38 Cr-Commit-Position: refs/heads/master@{#313778}
5 years, 10 months ago (2015-01-29 20:39:41 UTC) #4
inferno
On 2015/01/29 20:39:41, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 10 months ago (2015-01-29 20:43:25 UTC) #6
inferno
5 years, 10 months ago (2015-01-29 20:43:51 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/892503002/ by inferno@chromium.org.

The reason for reverting is: Wrong revert, ipc fuzzer broke because of something
else..

Powered by Google App Engine
This is Rietveld 408576698