Pass default renderer factory into CreateMediaRendererFactory

chromecast/renderer/cast_content_renderer_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/renderer/cast_content_renderer_client.h"
 
 #include <sys/sysinfo.h>
 
 #include "base/command_line.h"
 #include "base/memory/memory_pressure_listener.h"
@@ skipping 122 matching lines @@
 
 void CastContentRendererClient::AddKeySystems(
     std::vector< ::media::KeySystemInfo>* key_systems) {
   AddChromecastKeySystems(key_systems);
   AddChromecastPlatformKeySystems(key_systems);
 }
 
 #if !defined(OS_ANDROID)
 scoped_ptr<::media::RendererFactory>
 CastContentRendererClient::CreateMediaRendererFactory(
-    ::content::RenderFrame* render_frame) {
+    ::content::RenderFrame* render_frame,
+    scoped_ptr<media::DefaultRendererFactory> default_factory) {
   const base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess();
   if (!cmd_line->HasSwitch(switches::kEnableCmaMediaPipeline))
     return nullptr;
 
   return scoped_ptr<::media::RendererFactory>(

[DaleCurtis, 2015/02/17 19:48:15]

So in some future world you'll pass the default factory into this one and it'll
vend default or cma based renderers based on some criteria?

RendererFactory::CreateRenderer() seemingly doesn't give you enough context to
make that decision. Can you elaborate on what this future code might look like?

       new chromecast::media::CmaMediaRendererFactory(
           render_frame->GetRoutingID()));
 }
 #endif
 
 blink::WebPrescientNetworking*
 CastContentRendererClient::GetPrescientNetworking() {
   return prescient_networking_dispatcher_.get();
 }
 
 void CastContentRendererClient::DeferMediaLoad(
     content::RenderFrame* render_frame,
     const base::Closure& closure) {
   if (!render_frame->IsHidden()) {
     closure.Run();
     return;
   }
 
   // Lifetime is tied to |render_frame| via content::RenderFrameObserver.
   new CastMediaLoadDeferrer(render_frame, closure);
 }
 
 }  // namespace shell
 }  // namespace chromecast