Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 883353009: cc: Remove UseSkiaGpuBackend from pixel tests. (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove UseSkiaGpuBackend and ExpandedViewport from pixel tests. The UseSkiaGpuBackend is false always and not queried anywhere. I left this behind when I removed the Ganesh-in-GLRenderer thing we had before. The ExpandedViewport is slightly more mysterious but also not queried anywhere, so I guess leftover from refactorings. R=enne, vmpstr Committed: https://crrev.com/8f13743166dbcf1d5938fe438796a98d370f63a8 Cr-Commit-Position: refs/heads/master@{#314926}

Patch Set 1 #

Patch Set 2 : remove-use-skia-gpu: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
M cc/test/pixel_test.h View 1 3 chunks +0 lines, -59 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
danakj
5 years, 10 months ago (2015-02-05 23:19:35 UTC) #1
danakj
Some more bonus removal
5 years, 10 months ago (2015-02-05 23:21:58 UTC) #2
enne (OOO)
lgtm
5 years, 10 months ago (2015-02-05 23:22:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883353009/20001
5 years, 10 months ago (2015-02-05 23:23:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 00:44:54 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 00:45:46 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f13743166dbcf1d5938fe438796a98d370f63a8
Cr-Commit-Position: refs/heads/master@{#314926}

Powered by Google App Engine
This is Rietveld 408576698