Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 883353003: Skip displaying zoom levels for scheme and host zoom changes. (Closed)

Created:
5 years, 10 months ago by Sam McNally
Modified:
5 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip displaying zoom levels for scheme and host zoom changes. Currently, ContentSettingsHandler::UpdateZoomLevelsExceptionsView(), skips setting the origin for scheme and host zoom changes, but still adds an entry to be displayed in the content settings page. This causes an entry to be displayed with an origin of undefined. This CL changes UpdateZoomLevelsExceptionsView() to skip adding an entry altogether. BUG=453234 Committed: https://crrev.com/ed24b27948c5c04dadfb27b731129da6549e4459 Cr-Commit-Position: refs/heads/master@{#313839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
5 years, 10 months ago (2015-01-29 23:17:38 UTC) #2
Dan Beam
lgtm
5 years, 10 months ago (2015-01-30 00:29:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883353003/1
5 years, 10 months ago (2015-01-30 00:30:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 00:34:29 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 00:35:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed24b27948c5c04dadfb27b731129da6549e4459
Cr-Commit-Position: refs/heads/master@{#313839}

Powered by Google App Engine
This is Rietveld 408576698