Issue 883323004: Revert of Use ExclusiveStreamReader to lock Body.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 883323004: Revert of Use ExclusiveStreamReader to lock Body. (Closed)

Created:
5 years, 10 months ago by yhirano

Modified:
5 years, 10 months ago

Reviewers:
horo

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@exclusive-reader

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Use ExclusiveStreamReader to lock Body. (patchset #4 id:60001 of https://codereview.chromium.org/899653002/) Reason for revert: This change may cause a test crash: https://crbug.com/456047 Original issue's description: > Use ExclusiveStreamReader to lock Body. > > Use ExclusiveStreamReader to forbid a user from reading data via body > attribute. > > BUG=435393 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189611 TBR=horo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=435393 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189644

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -42 lines)			Patch
M	LayoutTests/http/tests/fetch/script-tests/stream-reader.js	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	Source/core/streams/ReadableStream.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/fetch/Body.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/modules/fetch/Body.cpp	View	5 chunks	+3 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

yhirano

Created Revert of Use ExclusiveStreamReader to lock Body.

5 years, 10 months ago (2015-02-06 14:04:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883323004/1

5 years, 10 months ago (2015-02-06 14:05:35 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-06 14:06:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189644