Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 883273002: Make Firefox nightly download more robust. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make Firefox nightly download more robust. The script will now only start complaining if we haven't been able to download anything for days. The script will always touch the file if the download is successful, so the modified time of the latest downloaded time is the benchmark of how fresh our Firefox build is. There can be many days between FF nightly release, sometimes weeks, so we only care if we managed to download something and not which date the build is from. BUG=360516 R=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/293895

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -28 lines) Patch
M download_firefox_nightly.py View 1 4 chunks +76 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
phoglund_chromium
5 years, 10 months ago (2015-01-29 14:15:25 UTC) #2
phoglund_chromium
ping
5 years, 10 months ago (2015-01-30 15:35:00 UTC) #3
kjellander_chromium
lgtm with a suggestion: now that you've already done some datetime stuff, maybe you can ...
5 years, 10 months ago (2015-01-30 19:11:36 UTC) #4
phoglund_chromium
I'll make a separate patch with archive cleaning then. https://codereview.chromium.org/883273002/diff/1/download_firefox_nightly.py File download_firefox_nightly.py (right): https://codereview.chromium.org/883273002/diff/1/download_firefox_nightly.py#newcode81 download_firefox_nightly.py:81: ...
5 years, 10 months ago (2015-02-02 09:07:54 UTC) #5
phoglund_chromium
5 years, 10 months ago (2015-02-02 09:08:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r293895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698