runtime/vm/ast.cc - Issue 883263004: Allows turning on checked mode on a per-isolate basis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/ast.cc

Issue 883263004: Allows turning on checked mode on a per-isolate basis (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/ast.cc

===================================================================

--- runtime/vm/ast.cc (revision 43426)

+++ runtime/vm/ast.cc (working copy)

@@ -515,7 +515,7 @@

if (field().is_final()) {

return NULL;

}

- if (FLAG_enable_type_checks) {

+ if (FLAG_enable_type_checks || Isolate::Current()->checked_mode()) {

srdjan 2015/02/03 22:04:12 I would factor this out into Isolate::IsCheckedMod

rhs = new AssignableNode(

field().token_pos(),

rhs,

@@ -574,7 +574,7 @@

ASSERT(!getter.IsNull() &&

(getter.kind() == RawFunction::kImplicitStaticFinalGetter));

#endif

- if (FLAG_enable_type_checks) {

+ if (FLAG_enable_type_checks || Isolate::Current()->checked_mode()) {

rhs = new AssignableNode(

field.token_pos(),

rhs,

« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | runtime/vm/class_finalizer.cc » ('J')